bunny_helper switch position #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ths relative to payload/
|
@kevthehermit Shouldn't it follow the format of the other variables of all caps? |
|
You added a whole different module. You might want to rebase everything that isn't in bunny_helpers.sh. |
|
Yeah just spotted that after i pushed the commit. |
kevthehermit
force-pushed
the
switchposition
branch
from
77d27f1
to
751c848
Compare
IMcPwn
suggested changes
Mar 4, 2017
| switch3=`cat /sys/class/gpio_sw/PL3/data` | ||
| echo "--- switch1 = $switch1, switch2 = $switch2, switch3 = $switch3" | ||
| if [ "x$switch1" = "x0" ] && [ "x$switch2" = "x1" ] && [ "x$switch3" = "x1" ]; then | ||
| SWITCH_POSITION="switch1" |
There was a problem hiding this comment.
Shouldn't the export be done here?
| if [ "x$switch1" = "x0" ] && [ "x$switch2" = "x1" ] && [ "x$switch3" = "x1" ]; then | ||
| SWITCH_POSITION="switch1" | ||
| elif [ "x$switch1" = "x1" ] && [ "x$switch2" = "x0" ] && [ "x$switch3" = "x1" ]; then | ||
| SWITCH_POSITION="switch2" |
There was a problem hiding this comment.
and here... etc. instead of at the bottom because wouldn't the bottom one just reset the variable to blank?
This was referenced Mar 4, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to use $switchposition in payloads. Useful for building paths relative to payload/