Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laplace to ChiSq Test #195

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mkhattab940
Copy link
Contributor

This one slipped through the cracks. Here's the failure:

### Failure in: 0:RoundTrip:0:3:t_laplace_to_stdChiSq:0
haskell/Tests/TestTools.hs:130
expected:
q <~ plate _ of 2: normal(+0/1, 1/1)
return real2prob(summate i from 0 to size(q): q[i] ^ 2)
but got:
q307 <~ normal(+0/1, 1/1)
q315 <~ normal(+0/1, 1/1)
return real2prob(q307 ^ 2 + q315 ^ 2)
Cases: 8  Tried: 7  Errors: 0  Failures: 6
                                          
### Failure in: 0:RoundTrip:0:3:t_laplace_to_stdChiSq:1
haskell/Tests/TestTools.hs:130
expected:
q <~ plate _ of 2: normal(+0/1, 1/1)
return real2prob(summate i from 0 to size(q): q[i] ^ 2)
but got:
X5 <~ gamma(1/1, 1/1)
Y3 <~ gamma(1/1, 1/1)
return abs(prob2real(X5) + prob2real(Y3) * (-1/1) + (-1/1)) * (2/1)
Cases: 8  Tried: 8  Errors: 0  Failures: 7

@JacquesCarette
Copy link
Contributor

The expected is wrong here, at least for failure 0, the 'got' is indeed what I expected.

Failure 1 is weird - I don't understand how a plate of normals becomes two gammas when inlining.

@mkhattab940
Copy link
Contributor Author

OK, fixed the 0-test. Failure looks like this now:

### Failure in: 6:RoundTrip:0:6:t_laplace_to_stdChiSq:1
haskell/Tests/TestTools.hs:130
expected:
X1 <~ normal(+0/1, 1/1)
X2 <~ normal(+0/1, 1/1)
return real2prob(X1 ^ 2 + X2 ^ 2)
but got:
X5 <~ gamma(1/1, 1/1)
Y3 <~ gamma(1/1, 1/1)
return abs(prob2real(X5) + prob2real(Y3) * (-1/1) + (-1/1)) * (2/1)
Cases: 172  Tried: 97  Errors: 0  Failures: 11
Cases: 172  Tried: 98  Errors: 0  Failures: 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants