added more events, ability to unitialize #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakimel
added a commit
that referenced
this pull request
Feb 17, 2014
|
Great stuff, thanks. I've merged this and bumped the version of Meny to 1.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Hakim. Thanks for such cool thing.
Due to problems, that meny (it's CSS transforms and other render-related things) introduces into DOM, I've written .destroy() method, that brings back original DOM state, styles and unbinds events. It's actually not so useful with touch events and threshold option, but makes meny usable on 'fat' webpages.
Also added closed and opened events for convenience. I'm using 'closed' event to destroy meny and 'opened' event for accurately producing magic after meny is triggered.