plug potential xss vector

hakimel · Oct 24, 2013 · f1f28f6 · f1f28f6
1 parent c7077cf
commit f1f28f6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/js/reveal.js b/js/reveal.js
@@ -191,9 +191,15 @@ var Reveal = (function(){
 		// Force a layout when the whole page, incl fonts, has loaded
 		window.addEventListener( 'load', layout, false );
 
+		var query = Reveal.getQueryHash();
+
+		// Do not accept new dependencies via query config to avoid
+		// the potential of malicious script injection
+		if( typeof query['dependencies'] !== 'undefined' ) delete query['dependencies'];
+
 		// Copy options over to our config object
 		extend( config, options );
-		extend( config, Reveal.getQueryHash() );
+		extend( config, query );
 
 		// Hide the address bar in mobile browsers
 		hideAddressBar();