CSS: Don't override font-weight for section (rebased on dev) #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.slides>section and .slides>section>section set the font-weight to "normal". This overrides any font-weight setting a theme may set at the body or .reveal level, and requires a theme author to also specifically set the font-weight for .slides>section and .slides>section>section. That's tedious and also counterintuitive. Adopt a saner default by setting the font-weight to inherit.
hakimel
added a commit
that referenced
this pull request
Nov 7, 2013
CSS: Don't override font-weight for section
|
Great, thanks for that! |
hakimel
added a commit
that referenced
this pull request
Nov 8, 2013
hakimel
added a commit
that referenced
this pull request
Nov 8, 2013
pulni
pushed a commit
to pulni/reveal.js
that referenced
this pull request
Nov 18, 2013
* upstream/dev: (92 commits) slide number changes; config value renamed, added to readme, moved to right side of screen make background transition default to exact same speed as normal transitions change transition easing for zooms rebuild css with change from hakimel#691 define normal font widths in all themes to make sure things look the same after hakimel#691 CSS: Don't override font-weight for section remove old inaccurate comment comments data-autoslide on vertical parent now applies to all child slides hakimel#685 ensure that all fragments on past slides are visible hakimel#684 add code slide to markdown example hakimel#682 readme adjustment Add slide attributes for single slide section case. Add mardown-based slide attribute examples. Add unit test for default slide attributes separator pattern. Remove console.log debugs, and fix tabs Fix default separator pattern for attribute in slide. Restore default notation for attributes in element. Restore proper pattern for attributes in elements. Add QUnit.js unit tests for attributes in Markdown slides. ...
m4dz
pushed a commit
to m4dz/reveal.js
that referenced
this pull request
Apr 16, 2014
enovajuan
pushed a commit
to enovajuan/reveal.js
that referenced
this pull request
Dec 2, 2014
CSS: Don't override font-weight for section
enovajuan
pushed a commit
to enovajuan/reveal.js
that referenced
this pull request
Dec 2, 2014
enovajuan
pushed a commit
to enovajuan/reveal.js
that referenced
this pull request
Dec 2, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.slides>section and .slides>section>section set the font-weight to
"normal". This overrides any font-weight setting a theme may set at
the body or .reveal level, and requires a theme author to also
specifically set the font-weight for .slides>section and
.slides>section>section. That's tedious and also counterintuitive.
Adopt a saner default by setting the font-weight to inherit.