Unified Attribute syntax for slides and elements generated from markdown #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- on slides: .slide x=y - on elements: .element x=y Those are detected in html comment, in order to not be visible if a markdown is edited in an html editor.
- Reformat. - Change default separator test 'slide: x=y'
- Reformat - Use new default separator format: '.element: x=y' - Add new tests for testing that default format
- new default separator for slide attributes - new default separator for element attributes Illustrate both, in html comments.
|
@hakimel Coiuld you please consider a 2.6.1? The current release is really not practical regarding the way it clumsily add 2 different syntax for adding attributes on markdown-generated slide and elements. |
|
Merged this in – the unified syntax is much nicer and the code looks cleaner as well. Nice job. Will release this as 2.6.1 through master soon. |
|
@hakimel Yes! Thank you :-) |
|
2.6.1 is in master https://github.com/hakimel/reveal.js/releases/tag/2.6.1 |
enovajuan
pushed a commit
to enovajuan/reveal.js
that referenced
this pull request
Dec 2, 2014
enovajuan
pushed a commit
to enovajuan/reveal.js
that referenced
this pull request
Dec 2, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #677 and #640:
See: