Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Unified Attribute syntax for slides and elements generated from markdown #734

Merged
merged 9 commits into from Dec 2, 2013

Conversation

Projects
None yet
2 participants
Contributor

VonC commented Nov 30, 2013

After #677 and #640:

  • I simplified the implementation of "adding attributes on elements or slides generated from markdown".
  • I used an unified syntax
<!-- .slide: xx=yy ww=zz -->
<!-- .element: xx=yy ww=zz -->

See:

VonC added some commits Nov 24, 2013

Simpler default syntax for markdown attributes.
- on slides: .slide x=y
- on elements: .element x=y

Those are detected in html comment, in order to not be visible
if a markdown is edited in an html editor.
test-markdown-attributes.*, new default separator
- Reformat.
- Change default separator test 'slide: x=y'
test-markdown-element-attributes: formats and test.
- Reformat
- Use new default separator format: '.element: x=y'
- Add new tests for testing that default format
README.md mentions the new default separators.
- new default separator for slide attributes
- new default separator for element attributes
Illustrate both, in html comments.
Contributor

VonC commented Nov 30, 2013

@hakimel Coiuld you please consider a 2.6.1?

The current release is really not practical regarding the way it clumsily add 2 different syntax for adding attributes on markdown-generated slide and elements.

hakimel added a commit that referenced this pull request Dec 2, 2013

@hakimel hakimel merged commit fdb03b4 into hakimel:dev Dec 2, 2013

1 check passed

default The Travis CI build passed
Details

hakimel added a commit that referenced this pull request Dec 2, 2013

Owner

hakimel commented Dec 2, 2013

Merged this in – the unified syntax is much nicer and the code looks cleaner as well. Nice job.

Will release this as 2.6.1 through master soon.

Contributor

VonC commented Dec 2, 2013

@hakimel Yes! Thank you :-)

enovajuan pushed a commit to enovajuan/reveal.js that referenced this pull request Dec 2, 2014

enovajuan pushed a commit to enovajuan/reveal.js that referenced this pull request Dec 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment