Attributes in markdown

[VonC]

Slide attributes in Markdown

Allow an external Markdown file to set attributes for each slide

(replace #639, because the pull request is now rebased on dev, not master):

<div class="slides">
      <section  data-markdown="training.md" 
                data-separator="^\n\n\n" 
                data-vertical="^\n\n" 
                data-notes="^Note:" 
                data-attributes="^\s*?--\s(.*?)$"        <=========
                data-charset="utf-8">
      </section>
      </div> <!-- slides -->

For example, that slide will set an id, transition and color:

## Plan:
-- id="plan" data-transition="zoom" data-background="#0f0f0f"

My plan is....

The slide attributes themselves are removed from the final markdown content, and not visible in the resulting html slide.

Incidentally, that should also solve #430 (Markdown Support for internal links);
Another slide can now refers to "plan" with:

[Link to Plan](#/plan)

[VonC]

@hakimel I have rebased this pull request on top of #677 that you just merged into dev.

I have also restored the initial pattern for attributes in elements {. xxx="yyy"}, and make sure the unit-test do test the ability to define a different pattern.
That means that c472ca3 fixes 080ae79.

You will find the same idea in the test/test-markdown-attributes.html unit test file, where data-attributes defines a different pattern than the one used by default.

[hakimel]

Nice. Can you also remove the debug code (console logs) and add an example to the readme that uses the default slide attribute separator?

[VonC]

@hakimel

Can you also remove the debug code (console logs) and add an example to the readme that uses the default slide attribute separator?

All done, and pushed, based on your latest dev branch.

[hakimel]

Thanks man! At work now but will merge this in shortly.

[VonC]

@hakimel I have rebased the attributes_in_markdown branch on top of your latest dev branch (7da98d8): the tests are still good.

[hakimel]

I've already pulled this into my local branch but haven't pushed it yet since I'm running into issues. Attributes are working in test but the following simple single-slide test doesn't work:

<section data-markdown>
    <script type="text/template">
        <!-- slide-attributes: data-background="#ff0000" -->
        ## Hello world
    </script>
</section>

Also what do you think about bringing this and the element attribute syntax closer together? I'd like there to be some theme to this since there's getting to be a lot of different separator expressions.

[VonC]

@hakimel "element syntax selection"? Are you talking about my previous markdown patch #677?

It yes, those are two different syntaxes for two different use cases. I'll prefer to see them separate. The default patterns are important (for classes in markdown-generated elements, it is an html comment, in order for those classes to not be displayed in an html preview, when using a markdown editor like https://stackedit.io/).

First, I'll include your case in the slide attributes unit tests, and debug that.

[hakimel]

That's meant to be element attribute syntax. Okay the usefulness of HTML comment syntax makes sense, so how about we define element attributes in the same way?

## Hello world <!-- element-attributes: class="fragment" -->

[VonC]

@hakimel Can you try again you test case?

<section data-markdown>
    <script type="text/template">
        <!-- slide-attributes: data-background="#ff0000" -->
        ## Hello world
    </script>
</section>

It should work now just fine. And the test cases have been updated to test just that scenario.

Once you have merge and published that on the branch hakimel/reveal.js@dev, I'll open a new issue/pull request to discuss how to merge markdown element attributes #677, and slide attributes (this pull request #640).

[hakimel]

Thanks for fixing that. I've merged this in.