-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace realpath occurrences with a custom function #114
Conversation
can this be merged? |
It is ready for review, and further discussion. If the maintainers approve, yes, it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@joschi Just wait a sec... do not merge yet. I forgot that we need to address if we should change in the Look on the original PR text... |
@fcrespo82 Sorry for the late response! I think it makes sense to update the @halcyon What do you think? |
@joschi @halcyon Yes, I think it makes sense too, but should I?
|
I'm leaning towards options 2 and 3.
|
Hi folks, I went with the approach number 2 to get this out of the way. If you find this should be changed, please let me know. Thanks! |
Thank you @fcrespo82 . LGTM! |
This pull request is aimed to fix #109
I only updated the code on the
functions
file, we should change in theset-java-home.*
files too. I just need to get your feedback if I should:functions
file on the other files where the function is needed.My personal preference would be for the first option, but I leave it here for discussion.