Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid validation warning for choices that are allowed to occur multiple times #955

Open
JohannaOtt opened this issue Mar 23, 2022 · 4 comments

Comments

@JohannaOtt
Copy link
Contributor

Description done with an example case to make the schema construct easier to understand: Work with omso:ProfileObservation

The element result.ReferenceableGridCoverage.rangeSet.ValueArray.valueComponents can contain multiple occurrences of the choice used in it. That means, if multiple values (e.g. AbstractValue.Count and AbstractValue.QuantityList) are provided for one object, the transformed data should be valid. But there is a validation warning:
grafik

According to the relevant schema,

  • ValueArray (expanding CompositeValue) is referencing valueComponent
  • valueComponents is using the ValueArrayPropertyType
  • the ValueArrayPropertyType is using a sequence with group:Value that can occur n times (unbounded)
    --> this means that it can be replaced by multiple group:Value elements (which are using various abstract elements respectively their children) and there should be no validation warning in hale studio
Copy link

github-actions bot commented May 8, 2024

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 8, 2024
@JohannaOtt JohannaOtt added pinned and removed stale labels May 8, 2024
@florianesser
Copy link
Member

florianesser commented May 22, 2024

@JohannaOtt I think this can only be investigated meaningfully with a reproduction case. Do you still happen to have the project that caused this problem?

I've tried to create a simple reproduction case (attached here) but couldn't get the same validation message when adding two Count elements to valueComponents. Would be great if you could check if the repro case does in fact recreate the situation that you reported, given that it uses the type ElevationGridCoverage instead of ReferenceableGridCoverage.
issue955.zip

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 22, 2024
@JohannaOtt
Copy link
Contributor Author

I created this repo case
955.zip

It has many validation warnings as I did not aim to fill al mandatory elements but it also has the validation warning described in this issue
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants