RunGen: bounds-query failure shouldn't matter if we use estimates anyway #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bounds_query_input_shapes() agressively fails if we can't complete the bounds-query, which can happen if the constraints on inputs are nontrivial. While we can (and should) improve the bounds-query logic to make this more robust, we shouldn't aggressively fail here in the first place, as the bounds-query shape(s) end up unused if we have estimates for the inputs (which we usually do). This just adds a ShapePromise type that wraps access to the resulting Shapes inside a function; if we never need the shape, the failure doesn't matter and never happens.
abadams
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bounds_query_input_shapes() agressively fails if we can't complete the bounds-query, which can happen if the constraints on inputs are nontrivial. While we can (and should) improve the bounds-query logic to make this more robust, we shouldn't aggressively fail here in the first place, as the bounds-query shape(s) end up unused if we have estimates for the inputs (which we usually do). This just adds a ShapePromise type that wraps access to the resulting Shapes inside a function; if we never need the shape, the failure doesn't matter and never happens.