Fix target detection for i686 #5675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
added
bug
backport me
steven-johnson
approved these changes
Jan 27, 2021
alexreinking
added a commit
that referenced
this pull request
Feb 13, 2021
(cherry picked from commit 813eadc)
alexreinking
added a commit
that referenced
this pull request
Feb 13, 2021
(cherry picked from commit 813eadc)
This was referenced Feb 13, 2021
alexreinking
removed
the
backport me
alexreinking
added a commit
that referenced
this pull request
Feb 13, 2021
(cherry picked from commit 813eadc)
alexreinking
added a commit
that referenced
this pull request
Feb 14, 2021
(cherry picked from commit 813eadc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User @calein in #5670 reported that
i686was not getting detected properly as anx86target when our CMake code tries to translate the CMake environment into a Halide target.This (ought to) fix that.