-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport outstanding changes to 10.0.1 #5734
Conversation
(cherry picked from commit 75077ed)
* Add 11.1 as an acceptable LLVM version Apparently 11.1 was released but our Makefile only allows for 11.0. * Update Makefile (cherry picked from commit 722b93e)
* Use pybind11 2.6.0, which fixes Python-finding bugs. * Update Generator.cpp * Update Generator.cpp * Update PyHalide.cpp * 2.6.0 -> 2.6.1 Co-authored-by: Steven Johnson <srj@google.com> (cherry picked from commit 8a12c43)
(cherry picked from commit 813eadc)
Looks like cuda is busted with this release on older llvms, because it tries to use a compute capability that didn't exist back then when the runtime detects it's available. Was the release broken? I don't see the change that added new cuda capabilities in the PR. |
It might well have been. This is running on the buildbots with newer GPUs, so that's likely why it wasn't caught earlier. Any suggestions? |
Maybe backport #5617 too? |
Wait, the description says you did |
LLVM10 can't handle that version of Cuda; we never noticed till now because we didn't have a buildbot with a GPU that could handle it. Modify the sniffers to cap capability at 75 for LLVM10 builds, and fail with user errors if that capability is explicitly requested. (cherry picked from commit 46fc56a)
Well, I did and then forgot to push! Let's see if this just works now. |
Now we're getting |
If it's the autoschedule faulting, then it's possible backporting #5694 would fix it. Don't worry about it too much though. That's the bot with the GPU from 2014, and the lens blur app is the one that allocates the most GPU memory. |
Up to you. If that fix would make things green, then I don't see why not. Otherwise, I think this is good to land. |
c138b04
to
16af11d
Compare
Ah, maybe it's #5538 that I need to backport. |
Some of them weren't the same as the Make equivalents, which meant that the test diverged between the two build systems (sometimes causing failures due to too-large images). (cherry picked from commit 382c807)
Great! Now we're all green. |
This backports #5388, #5403, #5538, #5617, #5640, #5644, and #5675 to release 10.0.1 (we should cut this soon, too).
This PR should be REBASED, not squashed