[xtensa] Added missing types to CodeGen_Xtensa.cpp and fixed the issues with 0_off_3 functions. #7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vksnk
changed the title
Aelphy
force-pushed
the
xtensa-codegen
branch
from
8621437
to
86580ed
Compare
Aelphy
force-pushed
the
xtensa-codegen
branch
from
86580ed
to
6a258a6
Compare
Aelphy
changed the title
vksnk
approved these changes
Nov 29, 2022
src/CodeGen_Xtensa.cpp
Outdated
| @@ -63,6 +63,46 @@ class UsesDmaCopy : public IRGraphVisitor { | |||
| bool uses_dma = false; | |||
| }; | |||
|
|
|||
| void CodeGen_Xtensa::add_platform_headers() { | |||
There was a problem hiding this comment.
Style question: this is named add_platform_headers() but doesn't actually add any headers, just explicit extern defines. Maybe it would be more helpful to name it something like add_platform_prologue()?
There was a problem hiding this comment.
fixed in #7186, where it belongs to
| @@ -1397,6 +1440,19 @@ HALIDE_ALWAYS_INLINE native_vector_u8 halide_xtensa_extract_0_of_3_u8(const nati | |||
| return halide_xtensa_extract_0_of_3_u8(a.native_vector[0], a.native_vector[1], a.native_vector[2]); | |||
| } | |||
|
|
|||
| HALIDE_ALWAYS_INLINE native_vector_i8 halide_xtensa_extract_0_of_3_i8(const native_vector_i8& a0, const native_vector_i8& a1, const native_vector_i8& a2) { | |||
There was a problem hiding this comment.
These changes look good but also look completely unrelated to add_platform_headers() -- you should either update the PR description to include these, or move them into a separate PR.
There was a problem hiding this comment.
moved platform_prologue stuff to #7186
src/XtensaOptimize.cpp
Outdated
| @@ -992,23 +992,23 @@ class MatchXtensaPatterns : public IRGraphMutator { | |||
| {mutate(op->vectors[0]), op->slice_begin() / 4}, Call::PureExtern); | |||
| } else if (op->type.is_int_or_uint() && (op->type.bits() == 8) && (op->type.lanes() == 64)) { | |||
| if ((op->vectors.size() == 1) && (op->vectors[0].type().lanes() == 192)) { | |||
| bool is_extract_off_0_3 = true; | |||
| bool is_extract_of_0_3 = true; | |||
There was a problem hiding this comment.
Do you mean "is_extract_0_of_3"?
vksnk
approved these changes
Nov 30, 2022
|
Ready to land? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.