Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake build rules for (some) of the generator jit tests #7693
base: main
Are you sure you want to change the base?
Add CMake build rules for (some) of the generator jit tests #7693
Changes from 10 commits
915c46d
a9d1af2
d3554b0
0a4a456
4727660
d3d40ca
585abef
f303262
7e97703
91a00df
ec9acfb
ca6a774
29ce2cf
25852f4
4f2e34c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unused but really shouldn't be... which target consumes it? It should be listed in the
target_sources
of that target.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, ok.
I'm also baffled by the build failures in apps/hannk -- something has somehow tickled the include paths in a way that makes no obvious sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a header file -- do those need to be in
target_sources
in CMake?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping re "It's just a header file -- do those need to be in target_sources in CMake?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the header file is generated, then it should be listed in some target, yes. Either:
DEPENDS
of a custom target; other targets that use the header shouldadd_dependencies
to that target.