Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use f-strings instead of Python 2 format operator #120

Closed
wants to merge 3 commits into from

Conversation

alexreinking
Copy link
Member

Making a safe, but not completely pointless, change to test GH Actions

@steven-johnson
Copy link
Contributor

Bleah, do we really have to use fstrings? I am fond of the old way.

@alexreinking
Copy link
Member Author

Bleah, do we really have to use fstrings? I am fond of the old way.

No. I just wanted to test a non-trivial change and this was easy to do automatically.

@alexreinking
Copy link
Member Author

That said, a couple of these changes might be worthwhile for readability. e.g:

- return '%s' % (self.halide_target())
+ return self.halide_target()

@alexreinking alexreinking deleted the format-string-cleanup branch January 5, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants