Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+left click is suggested but not recognized #14

Closed
leveluptor opened this issue Jan 19, 2018 · 8 comments
Closed

Ctrl+left click is suggested but not recognized #14

leveluptor opened this issue Jan 19, 2018 · 8 comments

Comments

@leveluptor
Copy link

When I go to declaration using Ctrl+left click, there is a popup which suggests using "Ctrl+B" or "Ctrl+Button1 Click", which seems to be what I'm doing anyway.

I noticed #11 but not sure if this is the same thing.

key-promoter-ctrl-click

IDEA version 2017.3.2, plugin version 5.11.

@halirutan
Copy link
Owner

IDEA sometimes has more than one short-cut for a particular action. I'm always displaying all short-cuts and since they are simple strings, I'm just presenting them without filtering out what you actually did. Maybe, when I have too much free time, I'm considering removing the mouse action you invoked from that list.

Currently, you'll have to live with this. You used a mouse action that has a short-cut so you're seeing all short-cuts. There are only a handful (if it is even a handful) of such actions and Go to declaration is one of them.

Nevertheless, thanks for sharing the issue.

@leveluptor
Copy link
Author

Thanks for the explanation! This is a very minor issue for me, just wanted to know if it works as expected.

@tlinkowski
Copy link

I also stumbled upon this issue.

I started removing other shortcuts, and I found out that the balloon is presented even if "Ctrl+Button1 Click" is the only shortcut. So it seems the plugin indeed does not recognize those mouse-related shortcuts. Is it expected (the plugin being a key promoter) or is it a bug?

Moreover, after reducing the number of shortucts, I found out there's actually a (Don't show again) link, which gets hidden if there are too many shortcuts (see the GIF posted by @leveluptor - you can only see the initial (D of this link there). I clicked this and it solved this problem for me but maybe this (Don't show again) should be moved to the next line?

@halirutan
Copy link
Owner

I clicked this and it solved this problem for me but maybe this (Don't show again) should be moved to the next line?

@tlinkowski That is a good idea.

Since most of the issues reported are about the mouse-shortcuts that appear in KPX, I will do some further digging if I can handle them more appropriately.

@jbeckers
Copy link

jbeckers commented Dec 7, 2018

Seeing the same thing with "back" aka "ctrl+alt+left" aka "button4 click" when I press the extra left button on the mouse.

I would argue that "Maybe, when I have too much free time, I'm considering removing the mouse action you invoked from that list." is not a great solution.
I'd say Key Promoter should not show a message at all, in this case.

In other words: if any of the short cuts for the action is in the list, no need to promote the others.

@halirutan
Copy link
Owner

In other words: if any of the short cuts for the action is in the list, no need to promote the others.

I'm not sure about this. AFAIK the middle mouse button can be used to navigate to a declaration. However, the goal is to use the keyboard's Ctrl+B and not take your hands off it and use the mouse to navigate.

So pushing this to the preferences and let the user decide is a much better way than to silently remove the hint.

@mazabin
Copy link

mazabin commented Feb 1, 2019

I created shortcut for action with no default shortcut - double click with a mouse wheel, but it's not recognized either.

I'm always displaying all short-cuts and since they are simple strings, I'm just presenting them without filtering out what you actually did.

This is not actually true.
Go to Declaration has by default few shortcuts: ctrl+b, ctrl+ left mouse button click.
Ctrl+B doesn't show the balloon, whereas ctrl+click does.

So in what I observed, no mouse-related shortcuts are recognized.

@halirutan
Copy link
Owner

@mazabin I read your message several times, but I'm confused. Let's start from the beginning:

double click with a mouse wheel, but it's not recognized either.

Have you in the latest release of KPX version 2019.1.1 turned off "Show Keyboard Shortcuts Only"? It's under Settings | Tools | Key Promoter X.

If I do this and create a shortcut for "Move Caret Backward a Paragraph" setting it to Ctrl+Alt+Shift+Mouse 2, I get

img

This is not actually true.
Go to Declaration has by default few shortcuts: ctrl+b, ctrl+ left mouse button click.
Ctrl+B doesn't show the balloon, whereas ctrl+click does.

It is a feature that nothing is displayed when you press Ctrl+B because the whole purpose of KPX is to show you shortcuts for mouse-actions. Once you know the short-cuts and actually use the keyboard, there is no use in displaying them again. Can you explain what you mean here?

So in what I observed, no mouse-related shortcuts are recognized.

I specifically introduced the new setting I mentioned above since there seems to be a general disagreement between users what to show and what not. You can see it directly in this issue. The OP of the issue complained that he doesn't want to see a notification for the mouse shortcut he is actually using. You on the other hand complain that you don't see a notification for you mouse action. #18 and #10 go into the same direction.

Therefore, I implemented the "Show Keyboard Shortcuts Only" which filters the list of shortcuts and selects only keyboard shortcuts. With this setting turned on, you will get

img

which doesn't show the Ctrl+Click shortcut. If the list of shortcuts is empty after removing all mouse actions, then nothing is displayed like in your case with the double-click. With the setting off, you will see

img

which includes the mouse shortcut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants