-
Notifications
You must be signed in to change notification settings - Fork 485
Conversation
@ruibaby is attempting to deploy a commit to the halo-dev Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
#### What type of PR is this? /kind api-change /kind improvement /milestone 2.0 #### What this PR does / why we need it: 重构 Dialog 组件使用 API 的调用方式,改为与 Toast 组件一致。#644 同样的,使用此方式调用 Dialog 组件不限制在 Vue 组件。 #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 需要测试后台各个操作的会话框是否正常。 #### Does this PR introduce a user-facing change? ```release-note 重构 Dialog 组件使用 API 的调用方式。 ```
#### What type of PR is this? /kind feature /milestone 2.0 #### What this PR does / why we need it: 添加 Toast 组件。 特性: 1. 支持相同消息合并。 2. 支持鼠标悬停。 使用方式: ```vue import { Toast } from '@halo-dev/components' Toast.success("Hello", { //props }) Toast.info("Hello", { //props }) Toast.warning("Hello", { //props }) Toast.error("Hello", { //props }) ``` props: ```ts export interface ToastProps { type?: Type; content?: string; duration?: number; closable?: boolean; frozenOnHover?: boolean; count?: 0; onClose?: () => void; } ``` Toast 方法不仅可以在 Vue 单组件中使用,理论上在任何地方均可使用。 #### Which issue(s) this PR fixes: Fixes halo-dev#2534 #### Screenshots: <img width="752" alt="image" src="https://user-images.githubusercontent.com/21301288/196099183-09e64daf-0077-4373-9603-5d4349dfce3d.png"> #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试方式: https://halo-admin-ui-git-fork-ruibaby-feat-toast-component-halo-dev.vercel.app/story/src-components-toast-toast-story-vue?variantId=_default 测试功能是否正常。 #### Does this PR introduce a user-facing change? ```release-note 添加 Toast 组件 ```
#### What type of PR is this? /kind api-change /kind improvement /milestone 2.0 #### What this PR does / why we need it: 重构 Dialog 组件使用 API 的调用方式,改为与 Toast 组件一致。halo-dev/console#644 同样的,使用此方式调用 Dialog 组件不限制在 Vue 组件。 #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 需要测试后台各个操作的会话框是否正常。 #### Does this PR introduce a user-facing change? ```release-note 重构 Dialog 组件使用 API 的调用方式。 ```
What type of PR is this?
/kind feature
/milestone 2.0
What this PR does / why we need it:
添加 Toast 组件。
特性:
使用方式:
props:
Toast 方法不仅可以在 Vue 单组件中使用,理论上在任何地方均可使用。
Which issue(s) this PR fixes:
Fixes halo-dev/halo#2534
Screenshots:
Special notes for your reviewer:
/cc @halo-dev/sig-halo-console
测试方式:
https://halo-admin-ui-git-fork-ruibaby-feat-toast-component-halo-dev.vercel.app/story/src-components-toast-toast-story-vue?variantId=_default
测试功能是否正常。
Does this PR introduce a user-facing change?