This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
refactor: use generateName instead of uuid to generate metadata.name #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/improvement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f2c-ci-robot
bot
added
the
needs-rebase
…teName-for-metadata.name
f2c-ci-robot
bot
removed
the
needs-rebase
|
/retitle WIP: refactor: use generateName instead of uuid to generate metadata.name |
f2c-ci-robot
bot
changed the title
f2c-ci-robot
bot
added
the
do-not-merge/work-in-progress
…Name-for-metadata.name
|
/retitle refactor: use generateName instead of uuid to generate metadata.name |
f2c-ci-robot
bot
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
f2c-ci-robot
bot
added
the
needs-rebase
|
Please resolve the conflicts before reviewing. |
…Name-for-metadata.name
Done |
f2c-ci-robot
bot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…alo-dev/console#688) #### What type of PR is this? /kind improvement /milestone 2.0 #### What this PR does / why we need it: 使用 metadata.generateName 代替 uuid 为 metadata.name 生成值。 Ref halo-dev#2563 #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试方式： 1. 需要 `pnpm install` 2. 测试登录以及所有需要创建更新资源的业务模块。 #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/milestone 2.0
What this PR does / why we need it:
使用 metadata.generateName 代替 uuid 为 metadata.name 生成值。
Ref halo-dev/halo#2563
Special notes for your reviewer:
/cc @halo-dev/sig-halo-console
测试方式：
pnpm installDoes this PR introduce a user-facing change?