Enable generating metadata name using generateName #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
the
release-note
f2c-ci-robot
bot
added
kind/feature
|
What is this if not talent? |
Signed-off-by: johnniang <johnniang@fastmail.com>
Signed-off-by: johnniang <johnniang@fastmail.com>
JohnNiang
force-pushed
the
feat/generate-name
branch
from
fec83bc
to
23fc2e9
Compare
|
/ping @halo-dev/sig-halo |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
f2c-ci-robot bot
pushed a commit
to halo-dev/console
that referenced
this pull request
Nov 18, 2022
…688) #### What type of PR is this? /kind improvement /milestone 2.0 #### What this PR does / why we need it: 使用 metadata.generateName 代替 uuid 为 metadata.name 生成值。 Ref halo-dev/halo#2563 #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试方式： 1. 需要 `pnpm install` 2. 测试登录以及所有需要创建更新资源的业务模块。 #### Does this PR introduce a user-facing change? ```release-note None ```
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…alo-dev/console#688) #### What type of PR is this? /kind improvement /milestone 2.0 #### What this PR does / why we need it: 使用 metadata.generateName 代替 uuid 为 metadata.name 生成值。 Ref halo-dev#2563 #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试方式： 1. 需要 `pnpm install` 2. 测试登录以及所有需要创建更新资源的业务模块。 #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area core
/milestone 2.0
What this PR does / why we need it:
See #2309 for more.
Which issue(s) this PR fixes:
Fixes #2309
Special notes for your reviewer:
Does this PR introduce a user-facing change?