Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: attachment management support sorting #694

Merged
merged 2 commits into from Nov 17, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 15, 2022

What type of PR is this?

/kind feature
/milestone 2.0

What this PR does / why we need it:

附件管理支持排序筛选,适配:halo-dev/halo#2705

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2627

Special notes for your reviewer:

/cc @halo-dev/sig-halo-console

测试方式:

  1. Halo 需要切换到 Provide sort query param for sorting attachment halo#2705 分支。
  2. Console 需要 pnpm install
  3. 上传若干附件,检查排序筛选之后的结果是否符合预期。

Does this PR introduce a user-facing change?

附件管理支持排序筛选

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 15, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Nov 15, 2022
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 15, 2022
@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Nov 17, 2022 at 2:51AM (UTC)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

That works very well.

image

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2022
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 17, 2022

New changes are detected. LGTM label has been removed.

@f2c-ci-robot f2c-ci-robot bot merged commit 1b8805a into halo-dev:main Nov 17, 2022
@ruibaby ruibaby deleted the feat/attachment-sort branch November 17, 2022 02:50
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind feature
/milestone 2.0

#### What this PR does / why we need it:

附件管理支持排序筛选,适配:halo-dev#2705

#### Which issue(s) this PR fixes:

Fixes halo-dev#2627

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo-console 

测试方式:

1. Halo 需要切换到 halo-dev#2705 分支。
2. Console 需要 `pnpm install`
3. 上传若干附件,检查排序筛选之后的结果是否符合预期。

#### Does this PR introduce a user-facing change?

```release-note
附件管理支持排序筛选
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
3 participants