Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

附件管理支持排序筛选 #2627

Closed
ruibaby opened this issue Oct 25, 2022 · 2 comments · Fixed by #2705 or halo-dev/console#694
Closed

附件管理支持排序筛选 #2627

ruibaby opened this issue Oct 25, 2022 · 2 comments · Fixed by #2705 or halo-dev/console#694
Assignees
@JohnNiang @ruibaby
Labels
area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@ruibaby
Copy link
Member

ruibaby commented Oct 25, 2022 •
edited

你当前使用的版本

2.0.0-alpha.2

描述一下此特性

目前在 Console 端的附件管理未支持排序筛选。期望支持。

/kind feature
/area core
/area console
/assign
/assign @JohnNiang

附加信息

No response
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 25, 2022

@ruibaby: GitHub didn't allow me to assign the following users: john.

Note that only halo-dev members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

你当前使用的版本

2.0.0-alpha.2

描述一下此特性

目前在 Console 端的附件管理未支持排序筛选。期望支持。

/kind feature
/area core
/area console
/assign
/assign @john

附加信息

No response

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. area/core Issues or PRs related to the Halo Core area/console Issues or PRs related to the Halo Console labels Oct 25, 2022
@ruibaby
Copy link
Member Author

ruibaby commented Oct 25, 2022

/assign @JohnNiang

@ruibaby ruibaby added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 14, 2022
@JohnNiang JohnNiang mentioned this issue Nov 15, 2022
Merged
@ruibaby ruibaby mentioned this issue Nov 15, 2022
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Nov 16, 2022
@JohnNiang
Provide sort query param for sorting attachment (#2705)
f1ac4e3 
#### What type of PR is this?

/kind feature
/area core
/milestone 2.0

#### What this PR does / why we need it:

Provide sort query param for sorting attachment. By default, we use creationTimestamp(desc) to sort the attachments.

Below is an example to sort with creationTimestamp(desc) and size(asc):

```bash
curl -X 'GET' \
  'http://localhost:8090/apis/api.console.halo.run/v1alpha1/attachments?sort=creationTimestamp%2Cdesc&sort=size%2Casc' \
  -H 'accept: */*'
```

#### Which issue(s) this PR fixes:

Fixes #2627

#### Does this PR introduce a user-facing change?

```release-note
附件列表支持排序
```
f2c-ci-robot bot pushed a commit to halo-dev/console that referenced this issue Nov 17, 2022
@ruibaby
feat: attachment management support sorting (#694)
1b8805a 
#### What type of PR is this?

/kind feature
/milestone 2.0

#### What this PR does / why we need it:

附件管理支持排序筛选，适配：halo-dev/halo#2705

#### Which issue(s) this PR fixes:

Fixes halo-dev/halo#2627

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo-console 

测试方式：

1. Halo 需要切换到 halo-dev/halo#2705 分支。
2. Console 需要 `pnpm install`
3. 上传若干附件，检查排序筛选之后的结果是否符合预期。

#### Does this PR introduce a user-facing change?

```release-note
附件管理支持排序筛选
```
JohnNiang pushed a commit to JohnNiang/halo that referenced this issue Mar 2, 2023
@ruibaby
feat: attachment management support sorting (halo-dev/console#694)
d85c10d 
#### What type of PR is this?

/kind feature
/milestone 2.0

#### What this PR does / why we need it:

附件管理支持排序筛选，适配：halo-dev#2705

#### Which issue(s) this PR fixes:

Fixes halo-dev#2627

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo-console 

测试方式：

1. Halo 需要切换到 halo-dev#2705 分支。
2. Console 需要 `pnpm install`
3. 上传若干附件，检查排序筛选之后的结果是否符合预期。

#### Does this PR introduce a user-facing change?

```release-note
附件管理支持排序筛选
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnNiang JohnNiang

@ruibaby ruibaby

Labels
area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
2 participants
@JohnNiang @ruibaby