This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 484
chore: bump @halo-dev/richtext-editor version #719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
kind/improvement
Categorizes issue or PR as related to a improvement.
labels
Nov 27, 2022
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f2c-ci-robot
bot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
and removed
release-note-none
Denotes a PR that doesn't merit a release note.
labels
Nov 27, 2022
JohnNiang
reviewed
Nov 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it manally, it works very well.
/lgtm
guqing
reviewed
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Nov 28, 2022
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind improvement /milestone 2.0.0-rc.2 #### What this PR does / why we need it: 升级 `@halo-dev/richtext-editor` 版本以支持图片放大缩小、嵌入网页、表格。 #### Which issue(s) this PR fixes: Fixes halo-dev#2681 #### Screenshots: <img width="1377" alt="image" src="https://user-images.githubusercontent.com/21301288/204129594-6b4c2b4e-4eb4-4cf5-b1ca-39097843fadf.png"> <img width="1375" alt="image" src="https://user-images.githubusercontent.com/21301288/204129660-e7c415eb-db70-405b-97cc-2ed05bcaa034.png"> #### Special notes for your reviewer: 测试方式: 1. 需要 `pnpm install` 2. 测试编辑器的图片放大缩小、嵌入网页、表格等功能。 #### Does this PR introduce a user-facing change? ```release-note Console 端编辑器支持图片放大缩小、嵌入网页、表格。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/improvement
Categorizes issue or PR as related to a improvement.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/milestone 2.0.0-rc.2
What this PR does / why we need it:
升级
@halo-dev/richtext-editor
版本以支持图片放大缩小、嵌入网页、表格。Which issue(s) this PR fixes:
Fixes halo-dev/halo#2681
Screenshots:
Special notes for your reviewer:
测试方式:
pnpm install
Does this PR introduce a user-facing change?