Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: add support for setting console's favicon #788

Merged
merged 3 commits into from
Dec 22, 2022
Merged

feat: add support for setting console's favicon #788

merged 3 commits into from
Dec 22, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 20, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Console 支持使用系统设置中的 Favicon。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3010

Screenshots:

2022-12-20 19 40 48

Special notes for your reviewer:

测试方式：

  1. 进入系统设置。
  2. 设置任意一个图片为 Favicon。
  3. 观察 Console 的站标是否被修改。

Does this PR introduce a user-facing change?

Console 端支持设置 Favicon

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 20, 2022
@vercel
Copy link

vercel bot commented Dec 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 22, 2022 at 4:21AM (UTC)

@wan92hen
Copy link
Contributor

如果 favicon 能被修改，logo 不能被修改会不会有有点奇怪。

@ruibaby
Copy link
Member Author

ruibaby commented Dec 21, 2022

如果 favicon 能被修改，logo 不能被修改会不会有有点奇怪。

现在没有这样的需求，而且产品 Logo 一般也是不让改的吧。

@wan92hen
Copy link
Contributor

如果 favicon 能被修改，logo 不能被修改会不会有有点奇怪。

现在没有这样的需求，而且产品 Logo 一般也是不让改的吧。

是这么个道理，但是 logo 和 favicon 的配置都在这个地方，一个影响控制台一个不影响就会觉得有些怪。

@ruibaby
Copy link
Member Author

ruibaby commented Dec 21, 2022

@wan92hen 那么有什么建议吗🌚

@wan92hen
Copy link
Contributor

@wan92hen 那么有什么建议吗🌚

像 WordPress 一样提供多个 favicon 配置如何？
image

@ruibaby
Copy link
Member Author

ruibaby commented Dec 21, 2022

@wan92hen 那么有什么建议吗🌚

像 WordPress 一样提供多个 favicon 配置如何？

image

确实是有计划的，halo-dev/halo#2582 (comment)

稍后我新建一个 issue。

@ruibaby ruibaby mentioned this pull request Dec 21, 2022
Open
@ruibaby
Copy link
Member Author

ruibaby commented Dec 22, 2022

当前还是按照这个 PR 进行。

/cc @halo-dev/sig-halo-console

JohnNiang
JohnNiang approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, wzrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2022
guqing
guqing reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 4029dd8 into halo-dev:main Dec 22, 2022
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
@ruibaby
feat: add support for setting console's favicon (halo-dev/console#788)
be4be85 
#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

Console 支持使用系统设置中的 Favicon。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3010

#### Screenshots:

![2022-12-20 19 40 48](https://user-images.githubusercontent.com/21301288/208658754-d62f9d46-7f15-412f-80e2-17fd9729ca8f.gif)


#### Special notes for your reviewer:

测试方式：

1. 进入系统设置。
2. 设置任意一个图片为 Favicon。
3. 观察 Console 的站标是否被修改。

#### Does this PR introduce a user-facing change?

```release-note
Console 端支持设置 Favicon
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@wzrove wzrove wzrove approved these changes

@QuentinHsu QuentinHsu Awaiting requested review from QuentinHsu

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

期望系统设置中的 Favicon 设置对 Console 端也生效
5 participants
@ruibaby @wan92hen @JohnNiang @guqing @wzrove