This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
refactor: request api of user data #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
/lgtm 没有角色权限的用户角色信息也能正常显示。
|
LIlGG
approved these changes
Feb 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, LIlGG The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 重构获取用户信息的请求方式，无需再请求所有角色即可获取当前用户的角色信息，适配：halo-dev#3372 相关 PR：halo-dev/console#847 #### Which issue(s) this PR fixes: Fixes halo-dev#3342 #### Special notes for your reviewer: 测试方式： 1. Halo 需要切换到 halo-dev#3372 分支。 2. Console 需要 `pnpm install && pnpm build:packages` 3. 测试用户列表、登录、检查角色信息是否显示正确。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端用户角色标识的显示名称。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
重构获取用户信息的请求方式，无需再请求所有角色即可获取当前用户的角色信息，适配：halo-dev/halo#3372
相关 PR：#847
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3342
Special notes for your reviewer:
测试方式：
pnpm install && pnpm build:packagesDoes this PR introduce a user-facing change?