Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add basic documentation for theme development #102

Merged
merged 7 commits into from
Nov 18, 2022
Merged

docs: add basic documentation for theme development #102

merged 7 commits into from
Nov 18, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 20, 2022 •
edited
Loading

添加最基本的主题开发文档，仅编写从创建主题项目到最终预览的部分。

/kind documentation

None

@ruibaby
docs: add basic documentation for theme development
713de76 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 20, 2022

@ruibaby: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 20, 2022
@vercel
Copy link

vercel bot commented Oct 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
halo-docs ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 4:28AM (UTC)

JohnNiang
JohnNiang reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有了扫描未安装主题功能后，这里的步骤可能需要调整一下。

@ruibaby
Copy link
Member Author

ruibaby commented Oct 27, 2022

有了扫描未安装主题功能后，这里的步骤可能需要调整一下。

https://github.com/halo-dev/docs/pull/102/files#diff-e59bd624e80f1134b8c77eda1e9bf9f42f499a98ca932baf9a0ff179638d0d26R89

已经有了。

liuzhihang
liuzhihang reviewed Oct 29, 2022
View reviewed changes
Copy link

@liuzhihang liuzhihang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ruibaby
Copy link
Member Author

ruibaby commented Nov 18, 2022

/retitle docs: add basic documentation for theme development

@f2c-ci-robot f2c-ci-robot bot changed the title WIP: docs: add basic documentation for theme development docs: add basic documentation for theme development Nov 18, 2022
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2022
@ruibaby
Copy link
Member Author

ruibaby commented Nov 18, 2022

/cc @halo-dev/sig-docs

JohnNiang
JohnNiang reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2022
guqing
guqing reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit f92e5ca into halo-dev:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang left review comments

@liuzhihang liuzhihang liuzhihang left review comments

@guqing guqing guqing left review comments

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruibaby @JohnNiang @liuzhihang @guqing