Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

文章访问次数统计不更新 #3448

Closed
Steven-WZH opened this issue Mar 3, 2023 · 6 comments · Fixed by #3471
Closed

文章访问次数统计不更新 #3448

Steven-WZH opened this issue Mar 3, 2023 · 6 comments · Fixed by #3471
Labels
area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug.
Milestone
2.3.1

Comments

@Steven-WZH
Copy link

Steven-WZH commented Mar 3, 2023 •
edited
Loading

What is version of Halo has the issue?

2.3.0

What database are you using?

H2

What is your deployment method?

Docker

Your site address.

https://blog.stevenw.cc/?p=halo-bao-ta-mian-ban-da-jian-halo-fan-xiang-dai-li

What happened?

image
可以访问一下https://blog.stevenw.cc/?p=halo-bao-ta-mian-ban-da-jian-halo-fan-xiang-dai-li
试试，访问次数老是不增长

Relevant log output

No response

Additional information

No response
@Steven-WZH
Copy link
Author

halo-log-2023-03-03 20_53.log

@Steven-WZH Steven-WZH changed the title 文章访问次数统计错误 文章访问次数统计不更新 Mar 3, 2023
@JohnNiang
Copy link
Member

/kind bug
/area core

curl 'https://blog.stevenw.cc/apis/api.halo.run/v1alpha1/trackers/counter' \
  -H 'authority: blog.stevenw.cc' \
  -H 'accept: */*' \
  -H 'accept-language: en-US,en;q=0.9' \
  -H 'content-type: application/json' \
  -H 'cookie: SESSION=79c59e57-07fe-4a83-acad-5e0c11b71dfa; browsertc=1' \
  -H 'origin: https://blog.stevenw.cc' \
  -H 'referer: https://blog.stevenw.cc/?p=office-tool-plus-huo-qu-mian-fei-office' \
  -H 'sec-ch-ua: "Chromium";v="110", "Not A(Brand";v="24", "Google Chrome";v="110"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  -H 'sec-fetch-dest: empty' \
  -H 'sec-fetch-mode: cors' \
  -H 'sec-fetch-site: same-origin' \
  -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36' \
  --data-raw '{"group":"content.halo.run","plural":"posts","name":"null","hostname":"blog.stevenw.cc","screen":"1512x982","language":"en-US","url":"/?p=office-tool-plus-huo-qu-mian-fei-office","referrer":"https://blog.stevenw.cc/"}' \
  --compressed

Counter 接口的请求体的 name 字段为 null。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Mar 3, 2023
@Steven-WZH
Copy link
Author

这个bug会在下个版本修复吗

@guqing
Copy link
Member

guqing commented Mar 5, 2023

这个bug会在下个版本修复吗

这周修复 然后发 patch 版本

@JohnNiang
Copy link
Member

/milestone 2.3.1

@f2c-ci-robot f2c-ci-robot bot added this to the 2.3.1 milestone Mar 5, 2023
@guqing
Copy link
Member

guqing commented Mar 6, 2023 •
edited
Loading

我测试了一下文章的访问量统计没有问题，自定义页面的有问题，应该是上次重构路由后出现的取值 name 有问题导致的，不过看你的网站访问量是有问题的，我会排查一下然后这周修复

@guqing guqing mentioned this issue Mar 7, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Mar 8, 2023
@guqing
fix: posts and pages cannot be counted for visits (#3471)
ce9c33c 
#### What type of PR is this?
/kind bug
/area core
/milestone 2.3.x

#### What this PR does / why we need it:
修复文章和自定义页面缺失 name 模型属性导致的访问量无法计数问题
此为 2.3.0 引入的问题 see #3300

how to test it?
1. 切换文章的路由为不带 name 的规则
2. 访问文章看 `/apis/api.halo.run/v1alpha1/trackers/counter` API 是否有如下参数，且 name 值正确
```json
{
    "group": "content.halo.run",
    "plural": "posts",
    "name": "335",
    "hostname": "localhost",
    "screen": "1920x1080",
    "language": "zh-CN",
    "url": "/?p=halo-150-released",
    "referrer": "http://localhost:8090/?p=how-to-development-a-halo-plugin"
}
```
3. 观察文章访问量是否有增加
4. 重复上述 2、3 步骤检查自定义页面的访问量功能是否正确

#### Which issue(s) this PR fixes:

Fixes #3448

#### Does this PR introduce a user-facing change?
```release-note
修复文章和自定义页面缺失属性导致的访问量无法计数问题
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.3.1
Development

Successfully merging a pull request may close this issue.

fix: posts and pages cannot be counted for visits guqing/halo
3 participants
@JohnNiang @guqing @Steven-WZH