Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

安装主题时如果已经安装过，期望能够提示升级 #3969

Closed
ruibaby opened this issue May 19, 2023 · 1 comment · Fixed by #3970
Closed

安装主题时如果已经安装过，期望能够提示升级 #3969

ruibaby opened this issue May 19, 2023 · 1 comment · Fixed by #3970
Assignees
@ruibaby
Labels
area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature.
Milestone
2.6.0

Comments

@ruibaby
Copy link
Member

ruibaby commented May 19, 2023

你当前使用的版本

2.5.2

描述一下此特性

目前插件支持在安装时接收到已安装的异常然后提示升级，所以期望主题能够实现同样的特性。

/area console
/kind feature

附加信息

No response
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. labels May 19, 2023
@ruibaby
Copy link
Member Author

ruibaby commented May 19, 2023

/assign

@ruibaby ruibaby added this to the 2.6.x milestone May 19, 2023
@ruibaby ruibaby mentioned this issue May 19, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this issue May 25, 2023
@ruibaby
feat: prompt to upgrade theme when installing existing theme (#3970)
533f0cf 
#### What type of PR is this?

/kind feature
/area console
/milestone 2.6.x

#### What this PR does / why we need it:

支持在安装已存在主题时提示是否升级主题。

<img width="611" alt="image" src="https://github.com/halo-dev/halo/assets/21301288/2e99c781-96b6-4900-9a37-2d472ad65411">
<img width="604" alt="image" src="https://github.com/halo-dev/halo/assets/21301288/a7bfa9d8-1522-417f-91b4-6ea3f75f693e">


#### Which issue(s) this PR fixes:

Fixes #3969 

#### Special notes for your reviewer:

测试方式：

1. 通过本地上传和远程下载的方式重复安装某个主题，观察是否可以正常提示升级以及测试升级是否正常。

#### Does this PR introduce a user-facing change?

```release-note
Console 端支持安装已存在主题时提示升级主题。
```
@ruibaby ruibaby modified the milestones: 2.6.x, 2.6.0 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

feat: prompt to upgrade theme when installing existing theme ruibaby/halo
1 participant
@ruibaby