Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prompt to upgrade theme when installing existing theme #3970

Merged
merged 2 commits into from May 25, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 19, 2023

What type of PR is this?

/kind feature
/area console
/milestone 2.6.x

What this PR does / why we need it:

支持在安装已存在主题时提示是否升级主题。

image image

Which issue(s) this PR fixes:

Fixes #3969

Special notes for your reviewer:

测试方式:

  1. 通过本地上传和远程下载的方式重复安装某个主题,观察是否可以正常提示升级以及测试升级是否正常。

Does this PR introduce a user-facing change?

Console 端支持安装已存在主题时提示升级主题。

@f2c-ci-robot f2c-ci-robot bot added this to the 2.6.x milestone May 19, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/console Issues or PRs related to the Halo Console labels May 19, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and lan-yonghui May 19, 2023 03:01
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #3970 (02f1cb5) into main (c22f158) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3970      +/-   ##
============================================
+ Coverage     60.47%   60.57%   +0.09%     
- Complexity     2343     2347       +4     
============================================
  Files           355      355              
  Lines         12099    12099              
  Branches        873      873              
============================================
+ Hits           7317     7329      +12     
+ Misses         4350     4338      -12     
  Partials        432      432              

see 4 files with indirect coverage changes

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 533f0cf into halo-dev:main May 25, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.6.x, 2.6.0 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

安装主题时如果已经安装过,期望能够提示升级
3 participants