Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

在进行某个三方登录时，期望禁用其他的登录方式。 #4064

Closed
ruibaby opened this issue Jun 12, 2023 · 1 comment · Fixed by #4066
Closed

在进行某个三方登录时，期望禁用其他的登录方式。 #4064

ruibaby opened this issue Jun 12, 2023 · 1 comment · Fixed by #4066
Assignees
@ruibaby
Labels
area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.7.0

Comments

@ruibaby
Copy link
Member

ruibaby commented Jun 12, 2023

你当前使用的版本

2.6.0

描述一下此特性

如图：

image

当前在进行某个三方登录的时候，其他登录方式没有进行禁用处理，可能会导致误点击。所以建议在登录时禁用其他方式不允许点击。

/kind improvement
/area console

附加信息

No response
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/console Issues or PRs related to the Halo Console labels Jun 12, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Jun 12, 2023

/assign

@ruibaby ruibaby mentioned this issue Jun 12, 2023
Merged
@ruibaby ruibaby added this to the 2.7.x milestone Jun 12, 2023
f2c-ci-robot bot pushed a commit that referenced this issue Jun 19, 2023
@ruibaby
perf: disallow repeated clicks when third-party login (#4066)
4a1fe8d 
#### What type of PR is this?

/area console
/kind improvement
/milestone 2.7.x

#### What this PR does / why we need it:

在使用某个三方登录的时候，禁用其他三方登录，防止重复点击。

#### Which issue(s) this PR fixes:

Fixes #4064 

#### Special notes for your reviewer:

测试方式：

1. 可安装 https://github.com/halo-sigs/plugin-oauth2 进行测试，可以不用配置各个登录方式，只需开启即可。
2. 在登录页面点击某个三方登录方式，观察所有三方登录方式的按钮是否被禁用。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端登录页面的三方登录方式按钮，禁用重复点击。
```
@ruibaby ruibaby modified the milestones: 2.7.x, 2.7.0 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

perf: disallow repeated clicks when third-party login ruibaby/halo
1 participant
@ruibaby