New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: disallow repeated clicks when third-party login #4066
perf: disallow repeated clicks when third-party login #4066
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4066 +/- ##
============================================
- Coverage 60.56% 60.49% -0.07%
Complexity 2386 2386
============================================
Files 356 356
Lines 12356 12367 +11
Branches 894 894
============================================
- Hits 7483 7482 -1
- Misses 4432 4444 +12
Partials 441 441
|
cc @halo-dev/sig-halo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/area console
/kind improvement
/milestone 2.7.x
What this PR does / why we need it:
在使用某个三方登录的时候,禁用其他三方登录,防止重复点击。
Which issue(s) this PR fixes:
Fixes #4064
Special notes for your reviewer:
测试方式:
Does this PR introduce a user-facing change?