Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: disallow repeated clicks when third-party login #4066

Merged
merged 2 commits into from Jun 19, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 12, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.7.x

What this PR does / why we need it:

在使用某个三方登录的时候,禁用其他三方登录,防止重复点击。

Which issue(s) this PR fixes:

Fixes #4064

Special notes for your reviewer:

测试方式:

  1. 可安装 https://github.com/halo-sigs/plugin-oauth2 进行测试,可以不用配置各个登录方式,只需开启即可。
  2. 在登录页面点击某个三方登录方式,观察所有三方登录方式的按钮是否被禁用。

Does this PR introduce a user-facing change?

优化 Console 端登录页面的三方登录方式按钮,禁用重复点击。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Jun 12, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.7.x milestone Jun 12, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #4066 (4def877) into main (997a73d) will decrease coverage by 0.07%.
The diff coverage is 12.50%.

@@             Coverage Diff              @@
##               main    #4066      +/-   ##
============================================
- Coverage     60.56%   60.49%   -0.07%     
  Complexity     2386     2386              
============================================
  Files           356      356              
  Lines         12356    12367      +11     
  Branches        894      894              
============================================
- Hits           7483     7482       -1     
- Misses         4432     4444      +12     
  Partials        441      441              
Impacted Files Coverage Δ
...in/java/run/halo/app/plugin/BasePluginFactory.java 11.76% <0.00%> (ø)
...in/java/run/halo/app/plugin/HaloPluginManager.java 6.82% <0.00%> (-0.43%) ⬇️
...pp/core/extension/reconciler/PluginReconciler.java 53.14% <100.00%> (-0.11%) ⬇️

@ruibaby
Copy link
Member Author

ruibaby commented Jun 14, 2023

cc @halo-dev/sig-halo

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@LIlGG
Copy link
Member

LIlGG commented Jun 19, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 4a1fe8d into halo-dev:main Jun 19, 2023
4 checks passed
@ruibaby ruibaby deleted the perf/improve-social-login branch June 19, 2023 02:38
@ruibaby ruibaby modified the milestones: 2.7.x, 2.7.0 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在进行某个三方登录时,期望禁用其他的登录方式。
3 participants