Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

当没有数据存在 deletionTimeStamp 的情况下启动时 GcSynchronizer 会查询到一个错误的结果集 #5324

Closed
guqing opened this issue Feb 4, 2024 · 2 comments · Fixed by #5325
Closed

当没有数据存在 deletionTimeStamp 的情况下启动时 GcSynchronizer 会查询到一个错误的结果集 #5324

guqing opened this issue Feb 4, 2024 · 2 comments · Fixed by #5325
Assignees
@guqing
Labels
area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug.
Milestone
2.12.2

Comments

@guqing
Copy link
Member

guqing commented Feb 4, 2024

Your current Halo version

2.12.1

Describe this feature

如标题所述，GcSynchronizer 会在启动时查询自定义模型中所有具有 deletionTimeStamp 的数据进行删除操作，但是当自定义模型对象都不存在 deletionTimeStamp 时会查询到全部数据如文章的记录导致启动时内存占用过大

Additional information

/kind bug
/area core
/milestone 2.13.x
/assign
@guqing guqing mentioned this issue Feb 4, 2024
Merged
@ruibaby
Copy link
Member

ruibaby commented Feb 5, 2024

/kind bug
/area core
/milestone 2.13.x
/assign

@guqing
Copy link
Member Author

guqing commented Feb 5, 2024

/assign

@guqing guqing added kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Feb 5, 2024
@guqing guqing added this to the 2.13.x milestone Feb 5, 2024
@guqing guqing self-assigned this Feb 5, 2024
@JohnNiang JohnNiang modified the milestones: 2.13.x, 2.12.2 Feb 5, 2024
f2c-ci-robot bot pushed a commit that referenced this issue Feb 5, 2024
@guqing
fix: possible incorrect result set obtained by Gc synchronizer when s…
06a44d0 
…artup (#5325)

#### What type of PR is this?
/kind bug
/area core
/milestone 2.13.x

#### What this PR does / why we need it:
修复启动时 GcSynchronizer 没有精准过滤出所需数据导致内存占用会出现较高峰值的问题

#### Which issue(s) this PR fixes:
Fixes #5324

#### Does this PR introduce a user-facing change?
```release-note
修复启动时 GcSynchronizer 没有精准过滤出所需数据导致内存占用会出现较高峰值的问题
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guqing guqing

Labels
area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.12.2
Development

Successfully merging a pull request may close this issue.

fix: possible incorrect result set obtained by Gc synchronizer when sartup guqing/halo
3 participants
@JohnNiang @ruibaby @guqing