Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: possible incorrect result set obtained by Gc synchronizer when sartup #5325

Merged
merged 1 commit into from Feb 5, 2024
Merged

fix: possible incorrect result set obtained by Gc synchronizer when sartup #5325

merged 1 commit into from Feb 5, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Feb 4, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.13.x

What this PR does / why we need it:

修复启动时 GcSynchronizer 没有精准过滤出所需数据导致内存占用会出现较高峰值的问题

Which issue(s) this PR fixes:

Fixes #5324

Does this PR introduce a user-facing change?

修复启动时 GcSynchronizer 没有精准过滤出所需数据导致内存占用会出现较高峰值的问题

@guqing
Copy link
Member Author

guqing commented Feb 4, 2024

/cherry-pick release-2.12

@guqing
Copy link
Member Author

guqing commented Feb 4, 2024

/hold

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2024
@guqing guqing force-pushed the bugfix/list-for-gc branch 2 times, most recently from 02c8bc7 to 9a99304 Compare February 4, 2024 14:20
@guqing
Copy link
Member Author

guqing commented Feb 4, 2024

/unhold

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2024 •
edited

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b4e1963) 57.11% compared to head (9a99304) 57.09%.
Report is 1 commits behind head on main.

Files Patch % Lines
...lo/app/extension/index/IndexedQueryEngineImpl.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #5325      +/-   ##
============================================
- Coverage     57.11%   57.09%   -0.03%     
+ Complexity     3334     3331       -3     
============================================
  Files           587      587              
  Lines         18965    18956       -9     
  Branches       1402     1401       -1     
============================================
- Hits          10832    10822      -10     
- Misses         7555     7556       +1     
  Partials        578      578

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing
Copy link
Member Author

guqing commented Feb 5, 2024 •
edited

5 万文章数据且启动时不需要运行 Reconciler 的情况下限制 800M 堆内存：

Before:

SCR-20240205-fqt

After:

SCR-20240205-etv

@ruibaby ruibaby requested a review from LIlGG February 5, 2024 04:05
ruibaby
ruibaby reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

JohnNiang
JohnNiang approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@JohnNiang JohnNiang added kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Feb 5, 2024
@JohnNiang JohnNiang added this to the 2.13.x milestone Feb 5, 2024
@JohnNiang
Copy link
Member

/cherry-pick release-2.12

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ruibaby
ruibaby approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 06a44d0 into halo-dev:main Feb 5, 2024
8 checks passed
@halo-dev-bot halo-dev-bot mentioned this pull request Feb 5, 2024
Merged
@halo-dev-bot
Copy link
Collaborator

@guqing: new pull request created: #5331

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing guqing deleted the bugfix/list-for-gc branch February 5, 2024 06:37
f2c-ci-robot bot pushed a commit that referenced this pull request Feb 5, 2024
@halo-dev-bot
[release-2.12] fix: possible incorrect result set obtained by Gc sync…
7da4968 
…hronizer when sartup (#5331)

This is an automated cherry-pick of #5325

/assign guqing

```release-note
修复启动时 GcSynchronizer 没有精准过滤出所需数据导致内存占用会出现较高峰值的问题
```
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@ruibaby ruibaby ruibaby approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
2.13.0
4 participants
@guqing @JohnNiang @halo-dev-bot @ruibaby