Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: accessing /install after initialization redirects to 404 #2225

Merged
merged 1 commit into from
Jul 8, 2022
Merged

perf: accessing /install after initialization redirects to 404 #2225

merged 1 commit into from
Jul 8, 2022

Conversation

cetr
Copy link
Member

@cetr cetr commented Jul 8, 2022 •
edited by guqing
Loading

What type of PR is this?

/kind improvement
/milestone 1.5.x
/area core

What this PR does / why we need it:

在halo安装完成后访问/install路径时会返回空白页，修改后返回404页面

Which issue(s) this PR fixes:

Fixes #2224

Special notes for your reviewer:

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 8, 2022
@CLAassistant
Copy link

CLAassistant commented Jul 8, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cetr cetr mentioned this pull request Jul 8, 2022
Closed
@cetr
Copy link
Member Author

cetr commented Jul 8, 2022

#2224

@JohnNiang
Copy link
Member

Hi @cetr ，建议根据 PR 模板 补充一下 PR 描述。

@cetr
Copy link
Member Author

cetr commented Jul 8, 2022

Hi @cetr ，建议根据 PR 模板 补充一下 PR 描述。

重新编辑了

@ruibaby
Copy link
Member

ruibaby commented Jul 8, 2022

/retitle perf: accessing /install after initialization redirects to 404

@f2c-ci-robot f2c-ci-robot bot changed the title 完善install路径返回的页面结果 perf: accessing /install after initialization redirects to 404 Jul 8, 2022
@ruibaby
Copy link
Member

ruibaby commented Jul 8, 2022

@JohnNiang 现在合并之后是将 PR 标题当做 commit message 吗？

@guqing
Copy link
Member

guqing commented Jul 8, 2022

#2225 (comment) 点击其中的 CLA bradge 签署一下证书

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 8, 2022
@JohnNiang
Copy link
Member

@JohnNiang 现在合并之后是将 PR 标题当做 commit message 吗？

确实会，我先去 prow 上配置一下吧。

@guqing
Copy link
Member

guqing commented Jul 8, 2022

/kind improvement

@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jul 8, 2022
@guqing guqing added this to the 1.5.x milestone Jul 8, 2022
@guqing guqing added the area/core Issues or PRs related to the Halo Core label Jul 8, 2022
guqing
guqing reviewed Jul 8, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@ruibaby
Copy link
Member

ruibaby commented Jul 8, 2022

/hold

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
JohnNiang
JohnNiang approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/cherry-pick release-1.5

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2022
ruibaby
ruibaby reviewed Jul 8, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/lgtm

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 003ff5a into halo-dev:master Jul 8, 2022
@JohnNiang
Copy link
Member

/cherry-pick release-1.5

@halo-dev-bot halo-dev-bot mentioned this pull request Jul 8, 2022
Merged
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #2226

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cetr cetr deleted the c1 branch July 8, 2022 16:28
f2c-ci-robot bot pushed a commit that referenced this pull request Oct 12, 2022
@guqing
release: 1.5.5 (#2541)
62bd454 
#### What type of PR is this?
/milestone 1.5.x

#### What this PR does / why we need it:
发布 1.5.5

#### Special notes for your reviewer:
```markdown
## Improvements
- 完善install路径返回的页面结果。#2225 @cetr 

## Bug Fixes
- 修改根据分类查询文章方法，使其同时返回子分类文章。#2405 @JustinLiang522
- 修复七牛云做附件存储时附件无法上传非图片文件的问题。#2331 @AirboZH
- 修复了当云存储中文件被删除时，在 Halo 同时删除多个附件会失败的问题。#2317 @JustinLiang522
- 修复文章详情页 meta_description 内容生成为空的问题。#2282 @guqing 
- 修复了无法设置日志、相册、链接页标题和每页显示条数的问题。halo-dev/console#601 @JustinLiang522
```
/cc @halo-dev/sig-halo 
#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@ruibaby ruibaby

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
1.5.x
Development

Successfully merging this pull request may close these issues.

在非首次安装系统后访问install路径返回空白页面
6 participants
@cetr @CLAassistant @JohnNiang @ruibaby @guqing @halo-dev-bot