-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provides authentication and authorization expression dialects #2729
Conversation
@guqing: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone 2.0.0-rc.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#### What type of PR is this? /kind improvement /milestone 2.0 #### What this PR does / why we need it: 使用 Pinia 管理已授权用户信息,并提供判断是否是 `anonymousUser` 的方式。 适配 halo-dev/halo#2729 #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试流程: 1. Halo 需要切换到 halo-dev/halo#2729 的分支。 2. 测试 Console 端的登录、退出等流程。 #### Does this PR introduce a user-facing change? ```release-note None ```
#### What type of PR is this? /kind bug /area core #### What this PR does / why we need it: The problem #2743 was introduced by #2729. This Pr mainly resolves it by setting SAMEORIGIN mode for frame options. ![image](https://user-images.githubusercontent.com/16865714/203795956-6efec450-da5f-4222-884d-5a67cb113173.png) #### Which issue(s) this PR fixes: Fixes #2743 #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note None ```
…#699) #### What type of PR is this? /kind improvement /milestone 2.0 #### What this PR does / why we need it: 使用 Pinia 管理已授权用户信息,并提供判断是否是 `anonymousUser` 的方式。 适配 halo-dev#2729 #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试流程: 1. Halo 需要切换到 halo-dev#2729 的分支。 2. 测试 Console 端的登录、退出等流程。 #### Does this PR introduce a user-facing change? ```release-note None ```
What type of PR is this?
/kind feature
/milestone 2.0.0-rc.1
/area core
What this PR does / why we need it:
主题端支持使用表达式方言获取登录状态和判断权限,例如:
获取当前登录用户名
关于判断登录状态我们并不推荐调用表达式
${#authentication.isAuthenticated()}
,因为始终返回true
,使用以下几种属性表达式代替:其他
更多请参考:
https://github.com/thymeleaf/thymeleaf-extras-springsecurity
Console 端判断是否登录需要改一下,目前所有未登录状态都属于一个叫 anonymousUser 的用户
Which issue(s) this PR fixes:
Fixes #2676
Special notes for your reviewer:
/cc @halo-dev/sig-halo
Does this PR introduce a user-facing change?