Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.3] fix: posts and pages cannot be counted for visits #3487

Conversation

halo-dev-bot
Copy link
Collaborator

This is an automated cherry-pick of #3471

/assign ruibaby

修复文章和自定义页面缺失属性导致的访问量无法计数问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 8, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen March 8, 2023 09:22
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone 2.3.x
/lgtm

@f2c-ci-robot f2c-ci-robot bot added this to the 2.3.x milestone Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #3487 (024a06a) into release-2.3 (6a9a1bd) will increase coverage by 0.42%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##             release-2.3    #3487      +/-   ##
=================================================
+ Coverage          61.14%   61.57%   +0.42%     
- Complexity          2466     2480      +14     
=================================================
  Files                393      393              
  Lines              12570    12572       +2     
  Branches            1019     1019              
=================================================
+ Hits                7686     7741      +55     
+ Misses              4398     4343      -55     
- Partials             486      488       +2     
Impacted Files Coverage Δ
...ava/run/halo/app/theme/router/SinglePageRoute.java 56.86% <100.00%> (+34.86%) ⬆️
...o/app/theme/router/factories/PostRouteFactory.java 55.67% <100.00%> (+0.46%) ⬆️
...lo/app/extension/controller/DefaultController.java 89.62% <0.00%> (+1.88%) ⬆️
.../halo/app/search/post/LucenePostSearchService.java 10.22% <0.00%> (+3.40%) ⬆️
.../run/halo/app/search/post/PostEventReconciler.java 27.94% <0.00%> (+4.41%) ⬆️
...a/run/halo/app/metrics/VisitedEventReconciler.java 37.28% <0.00%> (+6.77%) ⬆️
...ava/run/halo/app/metrics/ReplyEventReconciler.java 42.85% <0.00%> (+7.14%) ⬆️
src/main/java/run/halo/app/extension/Watcher.java 53.57% <0.00%> (+7.14%) ⬆️
...ava/run/halo/app/metrics/VotedEventReconciler.java 45.00% <0.00%> (+7.50%) ⬆️
.../halo/app/plugin/PluginCreatedEventReconciler.java 50.00% <0.00%> (+8.33%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit eb87116 into halo-dev:release-2.3 Mar 8, 2023
3 checks passed
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.1 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants