Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record the post query conditions in the route query parameters #4102

Merged
merged 7 commits into from Jul 12, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 21, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.8.x

What this PR does / why we need it:

在文章数据管理列表页面路由中记录查询条件,包括分页信息、筛选信息等。可以保证在刷新页面或者从文章编辑页面返回时保留之前的查询状态。

image

TODO:

  • 记录筛选条件,因为路由参数只能使用基本类型,但是原来的筛选条件的变量都是完整对象。

Which issue(s) this PR fixes:

Fixes #4098

Special notes for your reviewer:

需要测试:

  1. 文章管理列表的所有筛选项是否可以正常工作。
  2. 尝试设置部分筛选,然后刷新页面,观察筛选条件是否正常保留。

Does this PR introduce a user-facing change?

Console 端的文章管理列表支持在地址栏记录筛选条件。

@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Jun 21, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.7.x milestone Jun 21, 2023
@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 21, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and JohnNiang June 21, 2023 03:30
@ruibaby ruibaby changed the title feat: record the post query conditions in the route query parameters WIP: feat: record the post query conditions in the route query parameters Jun 21, 2023
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #4102 (ccc3717) into main (119f352) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4102      +/-   ##
============================================
- Coverage     60.18%   60.04%   -0.15%     
+ Complexity     2414     2409       -5     
============================================
  Files           366      366              
  Lines         12587    12587              
  Branches        906      906              
============================================
- Hits           7576     7558      -18     
- Misses         4571     4590      +19     
+ Partials        440      439       -1     

see 5 files with indirect coverage changes

@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2023
@ruibaby ruibaby modified the milestones: 2.7.x, 2.8.x Jun 26, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Jul 6, 2023

计划重构一下 Console 端数据列表的筛选项组件,然后再来完善此 PR。

@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2023
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 11, 2023
@ruibaby ruibaby changed the title WIP: feat: record the post query conditions in the route query parameters feat: record the post query conditions in the route query parameters Jul 11, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@LIlGG
Copy link
Member

LIlGG commented Jul 12, 2023

/lgtm

非常好用

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit bb0a5f1 into halo-dev:main Jul 12, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.8.x, 2.8.0 Jul 13, 2023
f2c-ci-robot bot pushed a commit that referenced this pull request Jul 16, 2023
…4222)

#### What type of PR is this?

/area console
/kind bug
/milestone 2.8.x

#### What this PR does / why we need it:

修复系统设置面板和插件设置面板无法正常显示的问题,此问题由 #4102 中升级了 `@vueuse/router` 导致。

#### Which issue(s) this PR fixes:

Fixes #4221 

#### Special notes for your reviewer:

需要测试:

1. 测试系统设置能否正常工作。
2. 测试插件的设置能否正常工作。

#### Does this PR introduce a user-facing change?

```release-note
None
```
@ruibaby ruibaby deleted the feat/store-post-query-params branch December 19, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于修改保存文章信息后自动跳转到列表首位的修改建议
3 participants