-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: system settings and plugin settings panels cannot be displayed #4222
fix: system settings and plugin settings panels cannot be displayed #4222
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4222 +/- ##
============================================
- Coverage 60.18% 60.04% -0.15%
+ Complexity 2414 2409 -5
============================================
Files 366 366
Lines 12587 12587
Branches 906 906
============================================
- Hits 7576 7558 -18
- Misses 4571 4590 +19
+ Partials 440 439 -1 |
Hi @ruibaby, CI 没过需要修复一下 |
Signed-off-by: Ryan Wang <i@ryanc.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area console
/kind bug
/milestone 2.8.x
What this PR does / why we need it:
修复系统设置面板和插件设置面板无法正常显示的问题,此问题由 #4102 中升级了
@vueuse/router
导致。Which issue(s) this PR fixes:
Fixes #4221
Special notes for your reviewer:
需要测试:
Does this PR introduce a user-facing change?