Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: system settings and plugin settings panels cannot be displayed #4222

Merged
merged 2 commits into from Jul 16, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 15, 2023

What type of PR is this?

/area console
/kind bug
/milestone 2.8.x

What this PR does / why we need it:

修复系统设置面板和插件设置面板无法正常显示的问题,此问题由 #4102 中升级了 @vueuse/router 导致。

Which issue(s) this PR fixes:

Fixes #4221

Special notes for your reviewer:

需要测试:

  1. 测试系统设置能否正常工作。
  2. 测试插件的设置能否正常工作。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/console Issues or PRs related to the Halo Console labels Jul 15, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.8.x milestone Jul 15, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from QuentinHsu and wzrove July 15, 2023 09:06
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 15, 2023
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #4222 (e372db1) into main (b1a6fe3) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4222      +/-   ##
============================================
- Coverage     60.18%   60.04%   -0.15%     
+ Complexity     2414     2409       -5     
============================================
  Files           366      366              
  Lines         12587    12587              
  Branches        906      906              
============================================
- Hits           7576     7558      -18     
- Misses         4571     4590      +19     
+ Partials        440      439       -1     

see 5 files with indirect coverage changes

@guqing
Copy link
Member

guqing commented Jul 16, 2023

Hi @ruibaby, CI 没过需要修复一下

经测试没有功能问题 Great 🎉
before:
image
In this PR:
image

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit ad9b0df into halo-dev:main Jul 16, 2023
4 checks passed
@ruibaby ruibaby deleted the fix/plugin-and-system-setting-tab branch July 16, 2023 16:14
@ruibaby ruibaby modified the milestones: 2.8.x, 2.8.0 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

插件的设置面板和系统设置面板无法正常显示
3 participants