refactor: logic of attachment data filtering #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <i@ryanc.cc>
f2c-ci-robot
bot
added
area/console
f2c-ci-robot
bot
added
the
kind/improvement
|
/hold 等待 #4193 合并，需要使用到其中重构用户筛选的部分。 |
f2c-ci-robot
bot
added
the
do-not-merge/hold
|
hi, 我看到 #4193 已经合并，此 pr 是否可以取消 hold 状态。 |
JohnNiang
approved these changes
Jul 13, 2023
f2c-ci-robot
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area console
/kind improvement
/milestone 2.8.x
What this PR does / why we need it:
重构附件数据管理的筛选条件逻辑以及 UI。
Ref #4182
Ref #4181
Special notes for your reviewer:
需要测试：
Does this PR introduce a user-facing change?