New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: data list filter components #4182
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4182 +/- ##
============================================
+ Coverage 60.04% 60.18% +0.14%
- Complexity 2409 2414 +5
============================================
Files 366 366
Lines 12587 12587
Branches 906 906
============================================
+ Hits 7558 7576 +18
+ Misses 4590 4571 -19
- Partials 439 440 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
🫡
#### What type of PR is this? /area console /kind improvement /milestone 2.8.x #### What this PR does / why we need it: 重构文章和页面数据管理的筛选条件逻辑以及 UI。 <img width="1646" alt="image" src="https://github.com/halo-dev/halo/assets/21301288/154c5588-91c0-448d-aa39-d75e90bce6ca"> Ref #4182 Ref #4181 #### Special notes for your reviewer: 需要测试: 1. 测试文章的筛选条件包括关键词筛选功能是否正常。 2. 测试页面的筛选条件包括关键词筛选功能是否正常。 #### Does this PR introduce a user-facing change? ```release-note 重构 Console 端文章数据列表的筛选项 UI 和逻辑。 ```
#### What type of PR is this? /area console /kind improvement /milestone 2.8.x #### What this PR does / why we need it: 重构评论数据管理的筛选条件逻辑以及 UI。 <img width="1650" alt="image" src="https://github.com/halo-dev/halo/assets/21301288/d89769bb-b8af-427e-a1ec-6ac8674131d3"> Ref #4182 Ref #4181 #### Special notes for your reviewer: 需要测试: 1. 测试评论的筛选条件包括关键词筛选功能是否正常。 #### Does this PR introduce a user-facing change? ```release-note 重构 Console 端评论数据列表的筛选项 UI 和逻辑。 ```
#### What type of PR is this? /area console /kind improvement /milestone 2.8.x #### What this PR does / why we need it: 重构附件数据管理的筛选条件逻辑以及 UI。 <img width="1645" alt="image" src="https://github.com/halo-dev/halo/assets/21301288/6b13045e-ab6b-4306-a1bb-f19d97115191"> Ref #4182 Ref #4181 #### Special notes for your reviewer: 需要测试: 1. 测试附件的筛选条件包括关键词筛选功能是否正常。 #### Does this PR introduce a user-facing change? ```release-note 重构 Console 端附件数据列表的筛选项 UI 和逻辑。 ```
What type of PR is this?
/area console
/kind improvement
/milestone 2.8.x
What this PR does / why we need it:
重构 Console 端数据列表的筛选项 UI,并提供全局的筛选列表组件和搜索输入框组件。
重构之后可以获得:
Which issue(s) this PR fixes:
Fixes #4181
Special notes for your reviewer:
需要测试:
Does this PR introduce a user-facing change?