Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: logic of comment data filtering #4195

Merged
merged 2 commits into from Jul 12, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 8, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.8.x

What this PR does / why we need it:

重构评论数据管理的筛选条件逻辑以及 UI。

image

Ref #4182
Ref #4181

Special notes for your reviewer:

需要测试:

  1. 测试评论的筛选条件包括关键词筛选功能是否正常。

Does this PR introduce a user-facing change?

重构 Console 端评论数据列表的筛选项 UI 和逻辑。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 8, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.8.x milestone Jul 8, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jul 8, 2023
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #4195 (73278d8) into main (c0aae3a) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4195      +/-   ##
============================================
- Coverage     60.14%   60.04%   -0.10%     
+ Complexity     2413     2409       -4     
============================================
  Files           366      366              
  Lines         12587    12587              
  Branches        906      906              
============================================
- Hits           7570     7558      -12     
- Misses         4578     4590      +12     
  Partials        439      439              

see 4 files with indirect coverage changes

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 1970963 into halo-dev:main Jul 12, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.8.x, 2.8.0 Jul 12, 2023
@ruibaby ruibaby deleted the refactor/comment-filter branch November 18, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants