New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: logic of comment data filtering #4195
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4195 +/- ##
============================================
- Coverage 60.14% 60.04% -0.10%
+ Complexity 2413 2409 -4
============================================
Files 366 366
Lines 12587 12587
Branches 906 906
============================================
- Hits 7570 7558 -12
- Misses 4578 4590 +12
Partials 439 439 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area console
/kind improvement
/milestone 2.8.x
What this PR does / why we need it:
重构评论数据管理的筛选条件逻辑以及 UI。
Ref #4182
Ref #4181
Special notes for your reviewer:
需要测试:
Does this PR introduce a user-facing change?