Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add issues field for plugin and theme manifest #5755

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 21, 2024

What type of PR is this?

/area core
/area ui
/kind feature
/kind api-change

What this PR does / why we need it:

为主题和插件的定义文件添加 issues 字段,用于填写问题反馈地址。方便使用者可以清楚的知道可以在哪里反馈问题。

image

Which issue(s) this PR fixes:

Fixes #5715

Does this PR introduce a user-facing change?

为主题和插件的定义文件添加问题反馈(issues)字段

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/core Issues or PRs related to the Halo Core labels Apr 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang April 21, 2024 04:25
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.52%. Comparing base (5fdf6c0) to head (c5fb3aa).
Report is 139 commits behind head on main.

Files Patch % Lines
.../main/java/run/halo/app/core/extension/Plugin.java 0.00% 1 Missing ⚠️
...c/main/java/run/halo/app/core/extension/Theme.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5755      +/-   ##
============================================
- Coverage     56.91%   56.52%   -0.39%     
- Complexity     3319     3339      +20     
============================================
  Files           587      598      +11     
  Lines         18968    19632     +664     
  Branches       1401     1360      -41     
============================================
+ Hits          10795    11097     +302     
- Misses         7594     7968     +374     
+ Partials        579      567      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里感觉用 feedback 可能会更合适。不过使用 issues 也可以接受。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ee76f19 into halo-dev:main Apr 26, 2024
8 checks passed
@ruibaby ruibaby added this to the 2.15.0 milestone Apr 26, 2024
f2c-ci-robot bot pushed a commit to halo-dev/plugin-starter that referenced this pull request Apr 26, 2024
为插件定义文件添加 issues 字段。

Refer halo-dev/halo#5755

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-dev/theme-earth that referenced this pull request Apr 28, 2024
为 theme.yaml 添加 issues 字段,适配:halo-dev/halo#5755

/kind improvement

```release-note
为 theme.yaml 添加 issues 字段
```
@ruibaby ruibaby deleted the feat/add-issues-field branch April 28, 2024 09:00
f2c-ci-robot bot pushed a commit to halo-dev/docs that referenced this pull request Apr 30, 2024
为主题和插件的配置文件示例添加 issues 字段。

Ref halo-dev/halo#5755

/kind documentation

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/ui Issues or PRs related to the Halo UI kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

为主题和插件的描述文件添加问题反馈链接的字段
3 participants