Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin lsky-pro #85

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Add plugin lsky-pro #85

merged 2 commits into from
Apr 28, 2024

Conversation

ichenhe
Copy link
Contributor

@ichenhe ichenhe commented Apr 27, 2024

集成 Lsky Pro 兰空图床作为 Halo 的存储后端。

Repo: https://github.com/ichenhe/halo-lsky-pro


麻烦帮忙发布到应用中心

None

@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby April 27, 2024 19:51
@f2c-ci-robot f2c-ci-robot bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 27, 2024
README.md Outdated Show resolved Hide resolved
@ruibaby
Copy link
Member

ruibaby commented Apr 28, 2024

感谢 @ichenhe 为 Halo 的生态做出贡献,我这里有一个小建议:为 plugin.yaml 添加 issues 字段,可以参考:halo-dev/halo#5755

这个建议不影响当前 PR 合并。

Co-authored-by: Ryan Wang <i@ryanc.cc>
@ichenhe
Copy link
Contributor Author

ichenhe commented Apr 28, 2024

@ruibaby

v0.1.1 已添加 issues 字段。另外请问后续更新要怎么同步到商店呢

@ruibaby
Copy link
Member

ruibaby commented Apr 28, 2024

@ruibaby

v0.1.1 已添加 issues 字段。另外请问后续更新要怎么同步到商店呢

暂时就只能用我这边的脚本来发布了。

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2024
Copy link

f2c-ci-robot bot commented Apr 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 943f5ab into halo-sigs:main Apr 28, 2024
1 check passed
@ruibaby
Copy link
Member

ruibaby commented Apr 28, 2024

已经发布在了 https://www.halo.run/store/apps/app-jZHhX

@ichenhe
Copy link
Contributor Author

ichenhe commented Apr 28, 2024

@ruibaby
v0.1.1 已添加 issues 字段。另外请问后续更新要怎么同步到商店呢

暂时就只能用我这边的脚本来发布了。

具体是:

  • 我需要在 Github Actions 中配置 cd.yaml
  • 还是需要以某种方式通知 f2c
  • 还是你们的脚本会自动扫描新版本

@ruibaby
Copy link
Member

ruibaby commented Apr 28, 2024

还是你们的脚本会自动扫描新版本

是这种方式。

目前只有官方维护的应用才可以使用 https://github.com/halo-sigs/reusable-workflows,因为目前应用市场还不支持开发者账号,所以开发者还没有办法利用这个 workflow 来进行版本发布。后续支持开发者账号之后,就可以利用此 workflow,只需要配置个人令牌即可。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants