-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CryptoService for simplifying RSA key generation #5978
Refactor CryptoService for simplifying RSA key generation #5978
Conversation
application/src/main/java/run/halo/app/security/authentication/impl/RsaKeyService.java
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5978 +/- ##
============================================
- Coverage 56.91% 56.68% -0.24%
- Complexity 3319 3474 +155
============================================
Files 587 609 +22
Lines 18968 20476 +1508
Branches 1401 1418 +17
============================================
+ Hits 10795 11606 +811
- Misses 7594 8292 +698
+ Partials 579 578 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5978 +/- ##
============================================
- Coverage 56.91% 56.68% -0.23%
- Complexity 3319 3475 +156
============================================
Files 587 609 +22
Lines 18968 20478 +1510
Branches 1401 1418 +17
============================================
+ Hits 10795 11608 +813
- Misses 7594 8292 +698
+ Partials 579 578 -1 ☔ View full report in Codecov by Sentry. |
37094a0
to
923c007
Compare
923c007
to
42ca0a3
Compare
Quality Gate passedIssues Measures |
application/src/main/java/run/halo/app/security/authentication/impl/RsaKeyService.java
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/area core
/milestone 2.16.x
What this PR does / why we need it:
This PR removes PatJwkSupplier interface, scheduled RSA key generation, and move some of them into CryptoService.
Currently, we only use
pat_id_rsa
as private key for authentication modules instead ofid_rsa
(deprecated).Does this PR introduce a user-facing change?