Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: improve code block styling in editor #6089

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 17, 2024

What type of PR is this?

/kind improvement
/area editor

What this PR does / why we need it:

优化编辑器代码块样式。

before:

image

after:

image

How to test it?

测试复制功能是否正常。

Does this PR introduce a user-facing change?

优化默认编辑器代码块样式

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby June 17, 2024 09:08
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Jun 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove June 17, 2024 09:08
@LIlGG
Copy link
Member Author

LIlGG commented Jun 17, 2024

/milestone 2.17.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.45%. Comparing base (5fdf6c0) to head (b48e46b).
Report is 234 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6089      +/-   ##
============================================
- Coverage     56.91%   56.45%   -0.46%     
- Complexity     3319     3540     +221     
============================================
  Files           587      623      +36     
  Lines         18968    20956    +1988     
  Branches       1401     1478      +77     
============================================
+ Hits          10795    11831    +1036     
- Misses         7594     8525     +931     
- Partials        579      600      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 1e37768 into halo-dev:main Jun 18, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants