Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove page cache feature #6108

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 20, 2024

What type of PR is this?

/area core
/kind api-change
/milestone 2.17.x

What this PR does / why we need it:

移除内置的页面静态缓存功能,后续将由 https://github.com/halo-sigs/plugin-page-cache 插件提供。

Which issue(s) this PR fixes:

Fixes #5639

Special notes for your reviewer:

Does this PR introduce a user-facing change?

移除内置的页面静态缓存功能,后续由 https://github.com/halo-sigs/plugin-page-cache 插件提供。

@ruibaby ruibaby marked this pull request as draft June 20, 2024 10:43
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/core Issues or PRs related to the Halo Core labels Jun 20, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 20, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jun 20, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG June 20, 2024 10:43
@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 20, 2024
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024
@ruibaby ruibaby marked this pull request as ready for review June 28, 2024 08:13
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing June 28, 2024 08:13
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby force-pushed the refactor/remove-page-cache-feature branch from 8a0b400 to 21ec5d3 Compare June 28, 2024 08:21
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.16%. Comparing base (bc10336) to head (21ec5d3).
Report is 28 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6108      +/-   ##
============================================
+ Coverage     54.51%   57.16%   +2.65%     
- Complexity     3523     3709     +186     
============================================
  Files           646      647       +1     
  Lines         21862    21947      +85     
  Branches       1528     1534       +6     
============================================
+ Hits          11917    12546     +629     
+ Misses         9328     8794     -534     
+ Partials        617      607      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@JohnNiang JohnNiang added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 28, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@JohnNiang JohnNiang added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
Copy link

f2c-ci-robot bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit f0445f4 into halo-dev:main Jun 28, 2024
7 checks passed
@ruibaby ruibaby deleted the refactor/remove-page-cache-feature branch June 28, 2024 10:10
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 28, 2024
f2c-ci-robot bot pushed a commit to halo-dev/docs that referenced this pull request Jul 1, 2024
移除部署文章的 `halo.cache.page.disabled` 参数,在 2.17 中已经[移除此功能](halo-dev/halo#6108 https://github.com/halo-sigs/plugin-page-cache 提供此功能。

/kind documentation

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望能够将内置的静态页面缓存封装为单独的插件
3 participants