Skip to content

Conversation

@guqing
Copy link
Member

@guqing guqing commented Jun 26, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.17.x

What this PR does / why we need it:

升级 pf4j 至 3.12.0 版本以解决插件依赖解析不正确的问题

Which issue(s) this PR fixes:

Fixes #5616

Does this PR introduce a user-facing change?

升级 pf4j 至 3.12.0 版本以解决插件依赖解析不正确的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen June 26, 2024 02:55
@codecov
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (5fdf6c0) to head (2ab22c2).
Report is 259 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6143      +/-   ##
============================================
- Coverage     56.91%   54.80%   -2.11%     
- Complexity     3319     3432     +113     
============================================
  Files           587      629      +42     
  Lines         18968    21185    +2217     
  Branches       1401     1482      +81     
============================================
+ Hits          10795    11610     +815     
- Misses         7594     8986    +1392     
- Partials        579      589      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit d6da4c6 into halo-dev:main Jun 26, 2024
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

先安装应用市场插件再安装 seo 插件并启用后卸载此时无法卸载应用市场插件

3 participants