Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: add the option to open a new window to the picture jump link #6170

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 27, 2024

What type of PR is this?

/kind improvement
/area editor
/milestone 2.17.x

What this PR does / why we need it:

为图片跳转链接增加在新窗口打开的选项。

How to test it?

测试新窗口打开是否正常可用。

Which issue(s) this PR fixes:

Fixes #6109

Does this PR introduce a user-facing change?

默认编辑器图片跳转链接支持配置新窗口打开

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from QuentinHsu and wzrove June 27, 2024 08:19
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.93%. Comparing base (bc10336) to head (79b67ac).
Report is 15 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6170      +/-   ##
============================================
+ Coverage     54.51%   56.93%   +2.42%     
- Complexity     3523     3702     +179     
============================================
  Files           646      652       +6     
  Lines         21862    22038     +176     
  Branches       1528     1537       +9     
============================================
+ Hits          11917    12547     +630     
+ Misses         9328     8885     -443     
+ Partials        617      606      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 0f6722a into halo-dev:main Jun 27, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 27, 2024
@LIlGG LIlGG deleted the pref/image-href-target branch July 1, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认编辑器图片跳转链接支持配置新窗口打开
3 participants