Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #748 #749

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Fix #748 #749

merged 1 commit into from
Apr 5, 2020

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 4, 2020

Resolved #748

@ruibaby ruibaby added the kind/bug Categorizes issue or PR as related to a bug. label Apr 4, 2020
@ruibaby ruibaby requested review from JohnNiang and guqing April 4, 2020 08:42
@ruibaby ruibaby self-assigned this Apr 4, 2020
@JohnNiang JohnNiang merged commit ba1eb8f into halo-dev:master Apr 5, 2020
@ruibaby ruibaby deleted the fix/748 branch April 8, 2020 04:02
ruibaby added a commit to ruibaby/halo that referenced this pull request Jun 11, 2021
@ruibaby
fix: halo-dev#748 (halo-dev#749)
73bea7a
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
@ruibaby
feat: refining the logic of user roles (halo-dev#749)
c70b069 
#### What type of PR is this?

/kind improvement
/milestone 2.0.1

#### What this PR does / why we need it:

完善用户角色的相关逻辑。适配 halo-dev#2865

1. 支持标识是否是系统保留角色。
2. 根据是否是系统保留角色，禁用修改和删除的操作。
3. 支持判断是否是超级管理员，如果是，默认勾选所有权限。
4. 优化 `包含 N 个权限` 文案的逻辑，超级管理员为 `包含所有权限`。
5. 优化 `基于此角色创建` 的逻辑，判断是否为超级管理员，如果是，需要设置所有角色模板到创建表单。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2844

#### Screenshots:

<img width="1663" alt="image" src="https://user-images.githubusercontent.com/21301288/205965292-b8f8e556-e06b-422b-b0be-8d87a68f18be.png">
<img width="1661" alt="image" src="https://user-images.githubusercontent.com/21301288/205965333-1491c023-6726-4cdd-b970-d868a30f3296.png">

#### Special notes for your reviewer:

测试方式：

1. Halo 需要切换到 halo-dev#2865 分支。
2. 测试角色相关的所有功能。

#### Does this PR introduce a user-facing change?


```release-note
完善 Console 端用户角色的相关逻辑
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

@ruibaby ruibaby

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

留言邮件中链接地址不完整 - 缺少博客地址
2 participants
@ruibaby @JohnNiang