Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

一个页面有多个评论组件时位置错乱 #7

Closed
wan92hen opened this issue Jan 12, 2023 · 1 comment · Fixed by #26
Closed

一个页面有多个评论组件时位置错乱 #7

wan92hen opened this issue Jan 12, 2023 · 1 comment · Fixed by #26

Comments

@wan92hen
Copy link

当页面中有多篇文章同时展示评论组件时，所有评论组件会全部展示在第一个评论组件的位置。
https://github.com/halo-sigs/plugin-comment-widget/blob/main/src/main/java/run/halo/comment/widget/DefaultCommentWidget.java#L48-L61
@ruibaby
Copy link
Member

ruibaby commented Jan 12, 2023

可以考虑在把 comment 这个 id 拼接上 name。

@ruibaby ruibaby mentioned this issue Mar 28, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Mar 29, 2023
@ruibaby
fix: emoji picker crash (#26)
895bf50 
修复 Emoji 选择组件无法正常初始化的问题。

原因是因为原来使用的 Emoji Mart 库可能会因为多次实例化导致异常，目前暂无解决方案，详情可查阅：missive/emoji-mart#812

目前改为使用 https://github.com/serebrov/emoji-mart-vue-test 代替。

Fixes #7
Ref #8 (comment)

```release-note
修复 Emoji 选择组件无法正常初始化的问题。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: emoji picker crash ruibaby/plugin-comment-widget
2 participants
@ruibaby @wan92hen