Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emoji picker crash #26

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 28, 2023

修复 Emoji 选择组件无法正常初始化的问题。

原因是因为原来使用的 Emoji Mart 库可能会因为多次实例化导致异常,目前暂无解决方案,详情可查阅:missive/emoji-mart#812

目前改为使用 https://github.com/serebrov/emoji-mart-vue-test 代替。

Fixes #7
Ref #8 (comment)

修复 Emoji 选择组件无法正常初始化的问题。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 28, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang March 28, 2023 06:16
@ruibaby
Copy link
Member Author

ruibaby commented Mar 28, 2023

/kind bug

@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 28, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 895bf50 into halo-dev:main Mar 29, 2023
@ruibaby ruibaby deleted the fix/emoji-picker-crash branch March 29, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

一个页面有多个评论组件时位置错乱
3 participants